208 update rxjava to rxjava2, also target sdk and build tools for latest stable Android Studio #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t, also gradle plugin for Stable AS, build tools version and build target
YuraLaguta
force-pushed
the
208-update-rxjava-to-rxjava2
branch
from
04ab355 to
46b0749
Compare
| rxJava : '1.1.8', | ||
| rxJavaProguardRules : '1.1.8.0', | ||
| rxLint : '1.0', | ||
| rxJava : '2.1.5', |
There was a problem hiding this comment.
You can't just update RxJava 1 to 2, it requires code changes :)
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-3.1-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-3.3-all.zip |
There was a problem hiding this comment.
This alone does not update gradle/wrapper/gradle-wrapper.jar and gradlew files
You'll need to run Gradle, ie ./gradlew --version
| buildTools : '23.0.3', | ||
| targetSdk : 25, | ||
| compileSdk : 25, | ||
| buildTools : '25.0.3', |
There was a problem hiding this comment.
This requires update of .travis.yml
|
Lemme update could CI related stuff, so such changes could be easier to merge |
Closed
vanniktech
suggested changes
Nov 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed : rxJavaProguardRules as per comment on that repo that it's not required for RxJava 2