Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dep: bump aspect-core to v0.4.7-rc1 #228

Merged
merged 1 commit into from
Dec 27, 2023
Merged

dep: bump aspect-core to v0.4.7-rc1 #228

merged 1 commit into from
Dec 27, 2023

Conversation

dumbeng
Copy link
Contributor

@dumbeng dumbeng commented Dec 27, 2023

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

0xYuan90
0xYuan90 approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@0xYuan90 0xYuan90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dumbeng dumbeng merged commit 068d2de into develop Dec 27, 2023
5 of 22 checks passed
@dumbeng dumbeng deleted the dep/bump-version branch December 27, 2023 03:36
0xDevVoyager added a commit that referenced this pull request Apr 16, 2024
@0xDevVoyager @0xYuan90
@gene-zhan @dumbeng
squash aspect commits (#373)
09dade8 
* fix: add BlockByHash

* fix: add BlockResults to TendermintRPC

* feat: add ConsensusParams interface

* temporary disable dependabot.yml

* feat: migration aspect

* feat: migration aspect

* feat: publish tag

* feat: publish tag

* fix: change  aspect-core version

* feat: implemented stuffs for on-tx-verify

* fix: fix dep

* chore: bump dep versions

* chore: bump aspect-core version to v0.4.3-beta

* chore: bump aspect core version to v0.4.4-beta (#183)

* fix: call of FilterTx

* fix: update artela tag

* clean: removed some unused code (#211)

* chore: clean unused code and add chain id method for base app

* fix: fix build issues

* dep: bump aspect-core to v0.4.7-beta

* dep: bump aspect-core to v0.4.7-rc1 (#228)

* refactor: update tag

* refactor: update tag (#236)

* update: v0.47-rc5

* chore: bump version v0.4.7-rc6

---------

Co-authored-by: Yuan <[email protected]>
Co-authored-by: Luke <[email protected]>
Co-authored-by: zhanjun <[email protected]>
Co-authored-by: Gene <[email protected]>
Co-authored-by: Jack Li <[email protected]>
Co-authored-by: Yuan <[email protected]>
Co-authored-by: No-Brainer <[email protected]>
0xDevVoyager added a commit that referenced this pull request Apr 16, 2024
@0xDevVoyager @0xYuan90
@gene-zhan @dumbeng
squash aspect commits (#373)
d12dc95 
* fix: add BlockByHash

* fix: add BlockResults to TendermintRPC

* feat: add ConsensusParams interface

* temporary disable dependabot.yml

* feat: migration aspect

* feat: migration aspect

* feat: publish tag

* feat: publish tag

* fix: change  aspect-core version

* feat: implemented stuffs for on-tx-verify

* fix: fix dep

* chore: bump dep versions

* chore: bump aspect-core version to v0.4.3-beta

* chore: bump aspect core version to v0.4.4-beta (#183)

* fix: call of FilterTx

* fix: update artela tag

* clean: removed some unused code (#211)

* chore: clean unused code and add chain id method for base app

* fix: fix build issues

* dep: bump aspect-core to v0.4.7-beta

* dep: bump aspect-core to v0.4.7-rc1 (#228)

* refactor: update tag

* refactor: update tag (#236)

* update: v0.47-rc5

* chore: bump version v0.4.7-rc6

---------

Co-authored-by: Yuan <[email protected]>
Co-authored-by: Luke <[email protected]>
Co-authored-by: zhanjun <[email protected]>
Co-authored-by: Gene <[email protected]>
Co-authored-by: Jack Li <[email protected]>
Co-authored-by: Yuan <[email protected]>
Co-authored-by: No-Brainer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xDevVoyager 0xDevVoyager 0xDevVoyager approved these changes

@0xYuan90 0xYuan90 0xYuan90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dumbeng @0xYuan90 @0xDevVoyager