-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persist Python interpreter for repeated use #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevein
force-pushed
the
dev/persistent-interpreter
branch
from
July 13, 2024 06:16
1f27016
to
d6d2170
Compare
djjuhasz
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces changes to ensure that the Python interpreter is persisted for repeated use, instead of creating a new instance with each method call. This is a low priority change, as it is only beneficial when using
*bagit.BagIt
repeatedly, e.g.: when validating hundreds of bags.ErrBusy
is returned if you try to use*bagit.BagIt
concurrently. If you need to perform concurrent validation you should have a dedicated*bagit.BagIt
instance per goroutine. Adding support for concurrent work in*bagit.BagIt
would be possible by implementing an internal pool of interpreters, but this does not seem necessary atm.Using
-benchtime=10s
shows that theValidate
method is significantly faster; within 10 seconds, we can now runValidate
approximately 1,200 times compared to the previous 144 times.Before:
After:
I've made changes to the Python script to improve error handling and reporting. See the following interaction in a terminal where each request (e.g.
INVALID-JSON
) always receives a JSON-encoded request even when malformed, and errors are now including atype
attribute with the name of the underlying Python exception.