Remove npm dependency on Ubuntu Xenial

[amayita]

Connects to #31

[mamedin]

Tested successfully on Ubuntu Xenial and Bionic.

[scollazo]

I'm not sure about this change. If npm is not needed for atom deployments, it should be also removed in all other envs (Bionic and CentOS) . @jraddaoui could you help us? Is npm needed for atom deployments?

[mamedin]

@scollazo, On Xenial npm command is included in nodejs package:

root@atom25-1604:~# sudo dpkg -S /usr/bin/npm
nodejs: /usr/bin/npm

But it is different in Bionic:

artefactual@tom25-1804:~$ sudo dpkg -S /usr/bin/npm
npm: /usr/bin/npm

artefactual@tom25-1804:~$ sudo dpkg -L nodejs | grep npm
artefactual@tom25-1804:~$ 

[jraddaoui]

Hi @scollazo,

Yes, we use it to install LESS in the same file at the bottom and it's also needed for Binder (atom_drmc: "yes").

[jraddaoui]

Although, I think we could remove nodejs from Bionic.

[amayita]

Although, I think we could remove nodejs from Bionic.

Thanks @jraddaoui , I'm about to test a new deploy on Bionic without nodejs package. I'll get back with my findings.

[scollazo]

@mamedin your explanation makes sense about why are we installing npm on bionic but not on xenial, I didn't knew that.

LGTM!

[amayita]

@jraddaoui nodejs was removed for Bionic because npm depends on it, so it will pull it at install.
This is ready for CR again

[scollazo]

It's better to be implicit than explicit, so instead of bringing nodejs as an npm dependecy, I would prefer to leave it listed in the role.

This all comes from my lack of knowledge about how npm was packaged in xenial/bionic, but @mamedin explained it.

[amayita]

It's better to be implicit than explicit, so instead of bringing nodejs as an npm dependecy, I would prefer to leave it listed in the role.

The thing is: it doesn't matter. nmp depends on nodejs. If nmp is installed, nodejs will be installed too. Whether you list it or not ,it will be installed.

The same way you don't list all the dependencies for every package you install, I see no need to list nodejs. But I don't care either way. I'm just trying to clarify my motives (and @jraddaoui 's who originally requested this change).

Please let me know, @scollazo if you agree with me now :)

[scollazo]

My concerns regarding explicit against implicit comes from following 12factor recomendations .

I personally prefer to have the "main" dependencies listed, instead of relying on them being brought as dependencies of other packages, but other than that, I don't have an strong opinion over doing it one way or the other, I leave it up to you.

As curiosity, CentOS nodejs package also carries npm ( https://github.com/artefactual-labs/ansible-atom/blob/master/tasks/deps-rh.yml#L42 )