Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix format-related Typesense report errors (#342) #343

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

mcantelon
Copy link
Member

@mcantelon mcantelon commented Sep 19, 2024

Don't bother doing a counts of formats, and format versions, of files matching report criteria if no formats, or format versions, were found (given that otherwise a multi-search Typesense query will be sent with no searches and will result in an HTTP 500 error).

@mcantelon mcantelon force-pushed the dev/formats-count-fix branch 3 times, most recently from 5618f1a to a481446 Compare September 19, 2024 03:23
@mcantelon mcantelon changed the title Fix Typesense format counts report error (#342) Fix format-related Typesense report errors (#342) Sep 19, 2024
@mcantelon mcantelon force-pushed the dev/formats-count-fix branch from a481446 to 7e910d2 Compare September 19, 2024 03:25
@mcantelon mcantelon marked this pull request as draft September 19, 2024 04:13
@mcantelon mcantelon force-pushed the dev/formats-count-fix branch from eb9153f to 53ffa83 Compare September 19, 2024 09:54
@mcantelon mcantelon force-pushed the dev/formats-count-fix branch 6 times, most recently from baddb45 to 0dc2d5b Compare September 28, 2024 05:17
@mcantelon mcantelon marked this pull request as ready for review September 28, 2024 05:20
Don't bother doing a counts of formats, and format versions, of files
matching report criteria if no formats, or format versions, were found
(given that otherwise a multi-search Typesense query will be sent with
no searches and will result in an HTTP 500 error).
Copy link

@djjuhasz djjuhasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mcantelon mcantelon merged commit 49b0478 into main Nov 21, 2024
6 checks passed
@mcantelon mcantelon deleted the dev/formats-count-fix branch November 25, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants