Add custom message to validation decorator (pinterest#1373)

arrowtail-precision · Jan 3, 2024 · f54d380 · f54d380
1 parent 49a413f
commit f54d380
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/...book/server/lib/query_analysis/validation/decorators/base_sqlglot_validation_decorator.py b/...book/server/lib/query_analysis/validation/decorators/base_sqlglot_validation_decorator.py
@@ -49,15 +49,18 @@ def _get_query_validation_result(
         end_index: int,
         suggestion: str = None,
         validation_result_object_type=QueryValidationResultObjectType.LINT,
+        message: str = None,
     ):
+        if message is None:
+            message = self.message
         start_line, start_ch = self._get_query_coordinate_by_index(query, start_index)
         end_line, end_ch = self._get_query_coordinate_by_index(query, end_index)
 
         return QueryValidationResult(
             start_line,
             start_ch,
             self.severity,
-            self.message,
+            message,
             validation_result_object_type,
             end_line=end_line,
             end_ch=end_ch,

diff --git a/querybook/server/lib/query_analysis/validation/validators/presto_optimizing_validator.py b/querybook/server/lib/query_analysis/validation/validators/presto_optimizing_validator.py
@@ -205,10 +205,6 @@ class PrestoOptimizingValidator(BaseQueryValidator):
     def languages(self):
         return ["presto", "trino"]
 
-    @property
-    def tokenizer(self) -> Tokenizer:
-        return Trino.Tokenizer()
-
     def _get_explain_validator(self):
         return PrestoExplainValidator("")