Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: expand package installing function with custom parameter #7124

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Aug 23, 2024

Description

  • Expand functions install_deb_chroot and install_artifact_deb_chroot with additional parameter. This adds support to pass additional parameters to package installer.
  • Enable allow-downgrades to base-files to allow building images with older version than current
  • Force cache rebuild just to make sure this Framework: disable armbian repository while generating rootfs cache #7123 is executed (I hope that would do, but it doesn't cover everything)

Framework stores our base-files in rootfs cache with version that comes from trunk and when we make stable images for current or previous release, build fails with error E: Packages were downgraded and -y was used without --allow-downgrades.

@rpardini I didn't find better ways.

#7048 AR-2350 AR-2454

How Has This Been Tested?

  • Manual tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

…ith accepting additional custom parameter

This adds support to pass additonal parameters to package installer.
…s with older version than current

Framework stores our base-files in rootfs cache with version that comes from trunk and when we make stable images for current or previous release, build fails with error  E: Packages were downgraded and -y was used without --allow-downgrades.
@igorpecovnik igorpecovnik requested a review from a team as a code owner August 23, 2024 04:56
@github-actions github-actions bot added size/small PR with less then 50 lines Framework Framework components labels Aug 23, 2024
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge Bugfix Pull request is fixing a bug 08 Milestone: Third quarter release labels Aug 23, 2024
@igorpecovnik igorpecovnik merged commit 71f5662 into main Aug 23, 2024
@igorpecovnik igorpecovnik deleted the base-files-fix branch August 23, 2024 04:59
NickAlilovic added a commit to NickAlilovic/build that referenced this pull request Sep 3, 2024
NickAlilovic added a commit to NickAlilovic/build that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
08 Milestone: Third quarter release Bugfix Pull request is fixing a bug Framework Framework components Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

1 participant