Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/extension in get server name #10

Conversation

robbieaverill
Copy link
Contributor

Commit 416f562 may not merge once #8 is merged - is here to ensure the build passes.

  • Add extension hook to getServerName method to allow modules to contribute to the server name/Zone ID retrieval
  • Add test for getServerName
  • Make CloudFlare extend Object so it can be extensible
  • Add EditorConfig file
  • Replace instance factory method (inst) with Object::singleton in a backward compatible fashioon

Resolves #9

@zanderwar
Copy link
Contributor

Thanks @robbieaverill

@zanderwar zanderwar merged commit 009bec6 into arkhi-digital:master Dec 5, 2016
@robbieaverill robbieaverill deleted the feature/extension-in-get-server-name branch December 5, 2016 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants