Parse fixes #12
Merged
Parse fixes #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplified TLS file paths by removing unnecessary relative segments. Improved the README installation guide for clarity and updated instructions for key generation. Bumped Rust version to 1.83.0, updated crate dependencies, and removed unused `zeroize`.
Added a size validation check for event payloads to ensure they do not exceed the maximum allowed size. Introduced improved logging to display the first 20 bytes of the payload in hexadecimal format for debugging purposes. Gracefully handle parsing failures with error messages and early returns.
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Introduce a payload size check to dynamically set the message type, addressing inconsistencies with large messages. This mitigates potential issues with handling message size and aligns processing with expected policies.
Renamed `handle_nats_event` to `handle_nats` for clarity and updated related logic. Simplified message type determination by replacing redundant comments and conditions.
Set `worker_threads` to 4 in the Tokio runtime initialization for better control over thread usage. Removed unnecessary attributes and redundant imports in generated FlatBuffers schema files, improving code maintainability and readability.
Increased `codegen-units` to 16 in release profile for faster builds. Updated `flatbuffers` to version 24.12.23 to include the latest enhancements and fixes. Ensured other dependencies remain consistent for compatibility.
Added print statements to log metadata buffer size, contents, and processed metadata during embedded policy handling. These changes improve visibility and aid in debugging metadata-related issues.
This change adds `#![allow(clippy::all)]` to suppress Clippy lints in files generated by the FlatBuffers compiler. These files are auto-generated, so manual linting is unnecessary and could lead to noise during development.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NATS Message Handling Improvements
handle_nats_eventtohandle_natsfor improved clarity and simplified message type determination logic.Runtime and Build Optimizations
worker_threadsset to 4 for better control over threading.codegen-unitsto 16 in the release profile for faster build times.flatbuffersto version 24.12.23 to incorporate the latest features and fixes.Schema and Code Cleanup
#![allow(clippy::all)]directive to suppress Clippy lints in auto-generated schema files, reducing noise during development.Debugging and Metadata Enhancements
Miscellaneous