-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components) $dispose not always called #306
Open
benouat
wants to merge
1
commit into
ariatemplates:master
Choose a base branch
from
benouat:components-lifecycle
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| <script> | ||
| /* | ||
| * Copyright 2013 Amadeus s.a.s. | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| var klass=require("hsp/klass"), | ||
| ht=require("hsp/utils/hashtester"); | ||
|
|
||
| var constructor_counter = 0; | ||
| var dispose_counter = 0; | ||
|
|
||
| var LifeCycleController = klass({ | ||
| $constructor: function() { | ||
| constructor_counter++; | ||
| }, | ||
| $dispose: function() { | ||
| dispose_counter++; | ||
| } | ||
| }); | ||
| </script> | ||
|
|
||
| <template lifecycle1 using ctrl:LifeCycleController> | ||
| <div class="content">I am component 1</div> | ||
| </template> | ||
|
|
||
| <template lifecycle2 using ctrl:LifeCycleController> | ||
| <div class="content">I am component 2</div> | ||
| </template> | ||
|
|
||
| <template wrapper(data)> | ||
| {if data.visible} | ||
| <#lifecycle1 /> | ||
| {/if} | ||
| </template> | ||
|
|
||
| <template dynamicWrapper(data)> | ||
| <#data.cpt /> | ||
| </template> | ||
|
|
||
| <script> | ||
| var data = { | ||
| visible: true, | ||
| cpt: lifecycle1 | ||
| }; | ||
| </script> | ||
|
|
||
| <script> | ||
| describe("Component lifecycle", function () { | ||
|
|
||
| it("should invoke $contructor and $dispose anytime a new instance is needed", function() { | ||
| var h=ht.newTestContext(); | ||
| constructor_counter = dispose_counter = 0; | ||
|
|
||
| wrapper(data).render(h.container); | ||
| expect(h(".content").text()).to.equal('I am component 1'); | ||
| expect(constructor_counter).to.equal(1); | ||
| h.$set(data, "visible", false); | ||
| h.$set(data, "visible", true); | ||
| expect(constructor_counter).to.equal(2); | ||
|
|
||
| expect(dispose_counter).to.equal(1); | ||
|
|
||
| h.$dispose(); | ||
| }); | ||
| }); | ||
|
|
||
| describe("Component used as dynamic <#ref >", function() { | ||
|
|
||
| it("should invoke $constructor at instance creation and $dispose when not needed anymore", function() { | ||
| var h=ht.newTestContext(); | ||
| constructor_counter = dispose_counter = 0; | ||
|
|
||
| dynamicWrapper(data).render(h.container); | ||
| expect(h(".content").text()).to.equal('I am component 1'); | ||
| expect(constructor_counter).to.equal(1); | ||
|
|
||
| h.$set(data, "cpt", lifecycle2); | ||
| expect(h(".content").text()).to.equal('I am component 2'); | ||
| expect(constructor_counter).to.equal(2); | ||
|
|
||
| h.$set(data, "cpt", lifecycle1); | ||
| expect(dispose_counter).to.equal(2); | ||
|
|
||
| h.$dispose(); | ||
| }); | ||
|
|
||
| }); | ||
| </script> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not enough as apparently the $dispose method is not called on the template root node (cf. $root.js line 120). So we should keep a reference on the template root node (which is returned when the template function is called) and call $dispose() on this reference. This should both dispose the node chain and the controller
(sorry I just realize this now!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is somehow valid, but could be done in another PR.
Nevertheless, the
$RootNode.$disposemethod as far as I get it is only called when we don't want to keeplocalPropertieson the node itself.