-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(github): Add checkrun support #223
base: master
Are you sure you want to change the base?
Conversation
davhdavh
commented
Sep 28, 2023
- Cleans up the github code so that each new template-supported prop only takes a single line (instead of 10+)
- Add support for CheckRuns
- Add a bit of documentation for all of the supported APIs
15aa525
to
b49553d
Compare
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
b2ac62c
to
4ba5076
Compare
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
That linter is really annoying, could it not just give ALL of the errors in 1 run, instead of taking 8... anyway, how to solve the last one?
|
Signed-off-by: Dennis Haney <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #223 +/- ##
==========================================
- Coverage 55.13% 54.74% -0.40%
==========================================
Files 35 35
Lines 3337 3352 +15
==========================================
- Hits 1840 1835 -5
- Misses 1230 1263 +33
+ Partials 267 254 -13
☔ View full report in Codecov by Sentry. |
Signed-off-by: Dennis Haney <[email protected]>
There is no existing tests for the api calls, so I have no idea how to make test for the new api call. |
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>