ci: add step to validate release manifests #14089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As requested in argoproj#14044 (comment), this adds a simple step to each E2E suite that validates the release manifests using server-side field validation. This is intended to catch simple issues, e.g. typos in a field: ``` $ make manifests-validate <SNIP> deployment.apps/postgres serverside-applied (server dry run) The CustomResourceDefinition "clusterworkflowtemplates.argoproj.io" is invalid: * spec.validation.openAPIV3Schema.properties[apiVersion].type: Invalid value: "TYPO": must be string * spec.validation.openAPIV3Schema.properties[apiVersion].type: Unsupported value: "TYPO": supported values: "array", "boolean", "integer", "number", "object", "string" make: *** [Makefile:452: manifests-validate] Error 1 ``` Signed-off-by: Mason Malone <[email protected]>
MasonM
force-pushed
the
add-manifest-validate
branch
from
3ff1ccd to
9589f09
Compare
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As requested in #14044 (comment), this adds a simple step to each E2E suite that validates the release manifests using server-side field validation. This is very fast (~2s) and is intended to catch syntactic issues, e.g. bugs in
hack/manifests/crds.go.Modifications
Add
make manifests-validatethat runs kubectl apply with--dry-run=serverto validate the manifests without actually applying them.Verification
Edited
manifests/quick-start-minimal.yamland changed this line:argo-workflows/manifests/quick-start-minimal.yaml
Line 23 in b1a65e7
to
type: TYPO, then ranmake manifests-validateto ensure it correctly caught the issue: