refactor(ui): artifacts table Fixes #8306 #14037
Conversation
…rtifacts to include column names and expand text on hover for individual rows Signed-off-by: Unperceivable <[email protected]>
Signed-off-by: Unperceivable <[email protected]>
Signed-off-by: Unperceivable <[email protected]>
| @@ -40,21 +40,34 @@ export function WorkflowArtifacts(props: Props) { | |||
| return ( | |||
| <div className='white-box'> | |||
| <div className='white-box__details'> | |||
| <div className='row header'> | |||
| <div className='columns download'>Download</div> | |||
There was a problem hiding this comment.
The download symbol in each row is self-explanatory enough.
we probably don't need this download column, or download column name, what do you think?
There was a problem hiding this comment.
Sure, I had tried both and settled for explicit over implicit but personally I think the download icon is clear enough too.
fixed in 359f5c4
That was the intended change, from Modifications:
The alternative suggested in the ticket was a horizontal scroll feature. I figured there would be edge cases where some columns would not appear until you scroll. |
… icon to artifact name column Signed-off-by: Unperceivable <[email protected]>
There was a problem hiding this comment.
Thank you for the fix, last few things:
-
Could you make sure the table values align with the column name, e.g., left align? People will definitely raise an issue about this later on.
-
we are already on artifact panel, rather than "Artifact Name", using "Name" is probably sufficient enough
-
I think we better have the timeformat switch button at the column title instead of individual artifact table value, just like the workflow list page. (we could tackle this in a separate PR, create an issue for this and a separate PR)
…tent Signed-off-by: Unperceivable <[email protected]>
Signed-off-by: Unperceivable <[email protected]>
Signed-off-by: Unperceivable <[email protected]>
Fixed padding issue ef7e1a1
Renamed column. but not in the node overview since there is no label to define artifacts in input/output 2f3b9da
Moved timestamp switch to column fe51106 |
…f row fix: node-info created-at header div missing Signed-off-by: Unperceivable <[email protected]>
tczhao
changed the title
Fixes #8306
Motivation
From original issue
Modifications
Refactored workflow-details artifacts white-box to include table columns and expand a cell with text too long for it's cell on hover.
Added same functionality to workflow-node-info -> inputs/outputs
Verification