feat: Fixes #8646 visualize wf before submitting #14034
Conversation
Signed-off-by: Unperceivable <[email protected]>
Signed-off-by: Unperceivable <[email protected]>
Signed-off-by: Unperceivable <[email protected]>
Signed-off-by: Unperceivable <[email protected]>
Signed-off-by: Unperceivable <[email protected]>
…gacy dependancies logic and extend support for enhances depends logic Signed-off-by: Unperceivable <[email protected]>
…en present Signed-off-by: Unperceivable <[email protected]>
Signed-off-by: Unperceivable <[email protected]>
…me of the buttons, not all options work, WIP Signed-off-by: Unperceivable <[email protected]>
Signed-off-by: Unperceivable <[email protected]>
gy and executionStrategy issues Signed-off-by: Unperceivable <[email protected]>
Signed-off-by: Unperceivable <[email protected]>
…bility, file length and reduce code duplication Signed-off-by: Unperceivable <[email protected]>
…ated functions to make control flow more legible Signed-off-by: Unperceivable <[email protected]>
Signed-off-by: Unperceivable <[email protected]>
Signed-off-by: Unperceivable <[email protected]>
Signed-off-by: Unperceivable <[email protected]>
| if ('workflowTemplateRef' in workflowDefinition.spec && isLoading) { | ||
| setWorkflowFromRefrence(workflowDefinition.spec.workflowTemplateRef.name).then(() => { | ||
| setIsLoading(false); | ||
| }); |
There was a problem hiding this comment.
cluster workflow template use case is missing
https://github.com/argoproj/argo-workflows/tree/main/examples/cluster-workflow-template
There was a problem hiding this comment.
Just to clarify, the usecase is for when you submit a manifest that uses a reference to a clusterWorkflowTemplate? Because currently there is no way to submit a clusterWorkflowTemplate via reference via selection in the UI right?
I assumed clusterWorkflowTemplates could not be submitted via reference for some reason...
There was a problem hiding this comment.
Added clusterWorkflowTemplate reference support: 180a142
There was a problem hiding this comment.
kind is optional so I have to cascade the calls either way I think. It could be written to only try cluster if the kind is available I guess. What do you think?
There was a problem hiding this comment.
Thanks for all the screenshots and commit ref, they are really helpful
For workflowTemplateRef to use clusterworkflow template, the clusterScope: true needs to be there, perhaps we should use this to determine if we should do a clusterworkflow template lookup instead of the current fallback method
There was a problem hiding this comment.
ah ok, clusterScope is also optional but has to be available when it's a cluster template. That makes sense, thanks for explaining.
Updated the logic: 0fdb470
… clusteWorkflowTemplate references Signed-off-by: Unperceivable <[email protected]>
Signed-off-by: Unperceivable <[email protected]>
…or not in setWorkflowFromReference Signed-off-by: Unperceivable <[email protected]>
Fixes #8646
Motivation
Stumbled across the open issue while developing a complex workflow, thought I might as well give it a go myself.
Disclaimer
First time doing any front-end development.
Modifications
Added a "graph view" tab to all workflow/template creation/submission pages to visualize the workflow as a graph before submission.
Verification
Ran all workflows/workflow-templates under ui/test/ui/ and visually compared the predicted graph view to the resultant output.
Possible Improvements