fix: search and replace null bytes for postgres only.Fixes #13711 #14030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: isubasinghe <[email protected]>
|
See #14004 (comment) and #14004 (comment) for the abandoning of two alternative implementations. |
isubasinghe
changed the title
tooptoop4
approved these changes
Dec 24, 2024
tczhao
approved these changes
Dec 31, 2024
MasonM
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
Good job! You could have a test for this by modifying one of the existing tests that submit a workflow to include a null byte and ensure it's decoded properly. I did basically the same thing in abdd9da#diff-fac0ae0f9b4361571a33c0b67333339a9a4c457bfff878f8d511aedd549f9cd8, except instead of a null byte, I used 👍
Signed-off-by: isubasinghe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Unfortunately postgres does not handle NULL bytes in the json, this is as a result of a non-compliant implementation of JSON that exists in postgres. See more details about this limitation here.
Modifications
This attempts a search and replace in postgres, it does this by reserving a special phrase for replacement of null bytes.
On the
GetWorkflowspath, this special phrase is replaced with a null byte.Verification
This has tests and additionally been verified by checking postgres.