Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SKIP_WORKFLOW_DURATION_ESTIMATION env var. Fixes #7271 #13745

Merged
merged 3 commits into from
Oct 12, 2024

Conversation

tooptoop4
Copy link
Contributor

Fixes #7271
co-authored by @talebzeghmi in zillow#1

@agilgur5 agilgur5 changed the title feat: SKIP_WORKFLOW_DURATION_ESTIMATION feat: SKIP_WORKFLOW_DURATION_ESTIMATION. Fixes #7271 Oct 12, 2024
@agilgur5 agilgur5 added the area/controller Controller issues, panics label Oct 12, 2024
Signed-off-by: Anton Gilgur <[email protected]>
Copy link

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me since this can be expensive, like in the case of #13382. And in general this can be a performance optimization for the Controller to skip this

@agilgur5 agilgur5 enabled auto-merge (squash) October 12, 2024 06:15
@agilgur5
Copy link

co-authored by @talebzeghmi in zillow#1

I also added them to the commit message as co-author, sourcing the name + email from argoproj/argo-events#3190

@agilgur5 agilgur5 changed the title feat: SKIP_WORKFLOW_DURATION_ESTIMATION. Fixes #7271 feat: add SKIP_WORKFLOW_DURATION_ESTIMATION env var. Fixes #7271 Oct 12, 2024
@agilgur5 agilgur5 merged commit ad114b0 into argoproj:main Oct 12, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller Controller issues, panics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to skip workflow duration estimation
2 participants