Add optional support for pydantic v1 models when v2 is installed #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambhav
force-pushed
the
pydanticv2
branch
2 times, most recently
from
a1fc78f to
0a84b39
Compare
sambhav
added
type:enhancement
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #897 +/- ##
=====================================
Coverage 79.7% 79.8%
=====================================
Files 45 45
Lines 3722 3736 +14
Branches 754 759 +5
=====================================
+ Hits 2970 2984 +14
+ Misses 558 557 -1
- Partials 194 195 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Sambhav Kothari <[email protected]>
elliotgunton
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description of PR
Currently, when pydantic v2 is used, users can only use v2 models.
This PR adds the ability to optionally provide v1 models to scripts.