Update default names in GroupColumns
#808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been built. You can view it at: https://distilabel.argilla.io/pr-808/ |
CodSpeed Performance ReportMerging #808 will not alter performanceComparing Summary
|
gabrielmbmb
approved these changes
Jul 23, 2024
plaguss
changed the title
GroupColumnsGroupColumns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the default name of the columns for
GroupColumns.As part of #758 we renamed some steps, but the default names were not updated. The
GroupColumnswill generate default column names asgroup_.... The oldCombineColumns(deprecated, to be removed in 1.5.0), as for the moment we just keep it as a copy ofGroupColumnswon't see any update, it should throw a warning like the following:Closes #800