Fix image import handling and update MlxLLM initialisation #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated image handling in `utils.py` and `image.py` to use forward references for the `Image` type, improving compatibility with type checkers. - Changed the initialization parameter in `MlxLLM` from `model` to `path_or_hf_repo` for clarity and consistency. - Removed unnecessary imports of `Image` in `text_generation_with_image.py` and `outlines.py`, and added conditional import for `pkg_resources` in `outlines.py`. These changes enhance type safety and code clarity across the image processing and LLM components.
davidberenstein1957
changed the title
|
Documentation for this PR has been built. You can view it at: https://distilabel.argilla.io/pr-1102/ |
… improve code clarity and maintainability.
CodSpeed Performance ReportMerging #1102 will not alter performanceComparing Summary
|
…emove it from the `vllm` section for improved clarity and consistency in dependency management.
…in `image.py` by cleaning up the code. This change enhances maintainability and prepares for future refactoring.
gabrielmbmb
approved these changes
Jan 17, 2025
plaguss
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.