-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add magpie support llama cpp ollama #1086
Merged
davidberenstein1957
merged 14 commits into
develop
from
feat/add-magpie-support-llama-cpp-ollama
Jan 8, 2025
Merged
Add magpie support llama cpp ollama #1086
davidberenstein1957
merged 14 commits into
develop
from
feat/add-magpie-support-llama-cpp-ollama
Jan 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1086 will not alter performanceComparing Summary
|
davidberenstein1957
changed the title
Feat/add magpie support llama cpp ollama
Add magpie support llama cpp ollama
Dec 24, 2024
Documentation for this PR has been built. You can view it at: https://distilabel.argilla.io/pr-1086/ |
burtenshaw
reviewed
Jan 8, 2025
burtenshaw
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor comments on documentation, but looks ok.
Co-authored-by: burtenshaw <[email protected]>
davidberenstein1957
deleted the
feat/add-magpie-support-llama-cpp-ollama
branch
January 8, 2025 16:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added extended support for Ollama and Llamacpp.
disitlabel.models
module.I looked into adding OpenAI API format for other providers but this does not work because tokenization is handled server-side and cannot be disabled out of the box.
Perhaps we can refactor the HF InferenceClient a bit to make this work.
Ollama
Llamacpp