-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix readme links to Doxygen and MOOSE resources #189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks good. I won't approve until all of the links are working, there is one that gives me a Not Found
error when I try to go there.
README.md
Outdated
[examples](http://mooseframework.org/wiki/MooseExamples/) to help understand the | ||
users who have never used MOOSE before are encouraged to check-out the MOOSE | ||
workshop [slides](https://mooseframework.inl.gov/workshop/index.html#/) and | ||
[video](https://www.youtube.com/watch?v=2tJwBsYaLaI) to help understand the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link works, but is an 11 hour video the best link to put?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. It's a tough call because MOOSE requires some time investment to gain basic proficiency. Should I just leave a link to the MOOSE website?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. I think that plus the slides would be helpful. I am assuming that the website will have the video linked if a user wants to invest the time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea I got the video link from their website. I'll link their website and workshop slides.
Co-authored-by: Amanda Bachmann <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Thanks for the work. I'll merge this.
Thanks! Lets merge your PR first just in case there are merge conflicts. |
PR #188 is merged, so I am merging this one. |
Fix readme links to Doxygen and MOOSE resources 7761c8c
Fix readme links to Doxygen and MOOSE resources 7761c8c
This PR addresses two issues highlighted in #187.