Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MI32 legacy: fix compilation with Bluetooth 5 #22506

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

Staars
Copy link
Contributor

@Staars Staars commented Nov 17, 2024

Description:

Fix compilation when building with Bluetooth 5 turned on.

The overall performance of BLE 5 on the ESP32 (ESP32-C3 in my last tests) is very underwhelming in my tests and did not improve in the last few months in the context of scanning. The only sensors with software support for BLE 5 that I know are the ones supported by the custom firmware from PVVX. I can clearly see, that I receive data on the Coded PHY (the longe range packets), but this does not gain a single meter in comparison to the same Xiaomi sensor without enabled long range. Both sensors (placed side by side) become invisible in the same distance.
I do not expect further improvements here and for me BLE 5 in the ESP32 family is only a pseudo feature, but I would be more than happy to be proven wrong.

Small addition to the packet parser to suppress unnecessary log messages.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.8
  • The code change is tested and works with Tasmota core ESP32 V.3.1.0.241117
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@Jason2866 Jason2866 merged commit 873bd3f into arendst:development Nov 17, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants