fix: edit url for block browser items

src/Repositories/Behaviors/HandleBlocks.php

@@ -450,25 +450,6 @@ protected function getBlockBrowsers($block)
         return Collection::make($block['content']['browsers'])->mapWithKeys(function ($ids, $relation) use ($block) {
             if ($this->hasRelatedTable() && $block->getRelated($relation)->isNotEmpty()) {
                 $items = $this->getFormFieldsForRelatedBrowser($block, $relation);
-                foreach ($items as &$item) {
-                    if (!isset($item['edit'])) {
-                        try {
-                            $item['edit'] = moduleRoute(
-                                $relation,
-                                config('twill.block_editor.browser_route_prefixes.' . $relation),
-                                'edit',
-                                $item['id']
-                            );
-                        } catch (RouteNotFoundException $e) {
-                            report($e);
-                            Log::notice(
-                                "Twill warning: The url for the \"{$relation}\" browser items can't " .
-                                "be resolved. You might be missing a {$relation} key in your " .
-                                'twill.block_editor.browser_route_prefixes configuration.'
-                            );
-                        }
-                    }
-                }
             } else {
                 try {
                     $relationRepository = $this->getModelRepository($relation);

src/Repositories/Behaviors/HandleBrowsers.php

@@ -230,16 +230,38 @@
                     'id' => $relatedElement->id,
                     'name' => $relatedElement->titleInBrowser ?? $relatedElement->$titleKey,
                     'endpointType' => $relatedElement->getMorphClass(),
-                ] + (empty($relatedElement->adminEditUrl) ? [] : [
-                    'edit' => $relatedElement->adminEditUrl,
-                ]) + (classHasTrait($relatedElement, HasMedias::class) ? [
+                    'edit' => $this->getAdminEditUrl($relatedElement),
+                ] + (classHasTrait($relatedElement, HasMedias::class) ? [
                     'thumbnail' => $relatedElement->defaultCmsImage(['w' => 100, 'h' => 100, 'fit' => 'crop']),
                 ] : []) : [];
         })->reject(function ($item) {
             return empty($item);
         })->values()->toArray();
     }
 
+    /**
+     * @param $object
+     * @return mixed|string
+     */
+    private function getAdminEditUrl($object): mixed
+    {
+        if (!empty($object->adminEditUrl)) {
+            return $object->adminEditUrl;
+        }
+
+        $relatedType = $object->getRelation('pivot')->related_type;
+        $relation = str_contains($relatedType, '\\')
+            ? getModuleNameByModel($relatedType)
+            : $relatedType;
+
+        return moduleRoute(
+            $relation,
+            config('twill.block_editor.browser_route_prefixes.' . $relation),
+            'edit',
+            $object->id
+        );
+    }
+
     /**
      * Get all browser' detail info from the $browsers attribute.
      * The missing information will be inferred by convention of Twill.