Pin release to 0.18.5 and turn on ALLOW_WARNINGS for builds

arduxio · Feb 7, 2024 · c3aab41 · c3aab41
1 parent 073d1f3
commit c3aab41
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -153,7 +153,7 @@ jobs:
                 cd /qmk_firmware;
                 git pull; 
             else 
-                git clone https://github.com/qmk/qmk_firmware.git /qmk_firmware/; 
+                git clone --branch 0.18.5 https://github.com/qmk/qmk_firmware.git /qmk_firmware/; 
             fi
             if [ ! -d /qmk_firmware/keyboards/ardux ];
             then
@@ -176,7 +176,7 @@ jobs:
       - name: QMK Build
         run: |
             cd /qmk_firmware/users/ardux
-            qmk compile -e ARDUX_SIZE=${{ matrix.size }} -e ARDUX_HAND=${{ matrix.hand }} layout/${{ matrix.layout }}.json
+            qmk compile -e ALLOW_WARNINGS=yes -e ARDUX_SIZE=${{ matrix.size }} -e ARDUX_HAND=${{ matrix.hand }} layout/${{ matrix.layout }}.json
       - name: Debug - ls build artifact folder
         run: ls /qmk_firmware/.build
       - name: Prep artifacts

diff --git a/DEVELOPMENT.md b/DEVELOPMENT.md
@@ -18,6 +18,7 @@ If these commands don't work, please ensure you've completed all steps per the Q
 
 ``` sh
 cd /qmk_firmware/users/ardux
+# ALLOW_WARNINGS is a required argument as of QMK 0.18. Otherwise warnings will kill your build
 # ARDUX_SIZE is a required argument
 # ARDUX_HAND is a required argument
 # ARDUX_OLED_BOOT_LOGO is an optional argument. default: yes
@@ -38,7 +39,8 @@ cd /qmk_firmware/users/ardux
 # ENCODER_ENABLE whether or not to include encoder support. default: no ; uses just over 1k of rom space which is quite large
 # RGBLIGHT_ENABLE whether or not to turn on some underglow features. default: no ; uses a TON of rom space and we need a lot for 40% ardux to work
 # SPLIT_USB_DETECT use this option (see kemo builds) when using an unmodified miranda or old elite-c
-qmk -v compile -e ARDUX_SIZE=[std|big|40p] \
+qmk -v compile -e ALLOW_WARNINGS=yes
+               -e ARDUX_SIZE=[std|big|40p] \
                -e ARDUX_HAND=[left|right] \
                -e ARDUX_OLED_BOOT_LOGO=[yes|no] \
                -e ARDUX_BOOT_LOGO_TIMEOUT=[ms] \