Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CurieBLE: Correct EIR length calculations #544

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sandeepmistry
Copy link
Contributor

Fixes #543.

Corrects two things:

  1. lengthOfScanRsp was never updated
  2. Space calculations where not taking EIR header length (2 bytes) into account

@SidLeung please consider this change for Elnath, if it is too late for Bootes.

cc/ @CarlaMSedze @rodriguezcarlos

@sandeepmistry sandeepmistry force-pushed the advertisement-fixes branch from 5a58b32 to 7fa8a3d Compare May 12, 2017 13:22
@SidLeung SidLeung requested a review from russmcinnis May 17, 2017 21:40
@SidLeung SidLeung added this to the Elnath milestone May 17, 2017
@SidLeung SidLeung added the bug label May 17, 2017
@SidLeung
Copy link
Contributor

@russmcinnis , please perform system testing and inform @yashaswini-hanji upon successful completion. Thanks.

@kitsunami kitsunami removed this from the Elnath milestone Aug 30, 2017
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CurieBLE: advertising doesn't work with longer local names
5 participants