Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSOC2020: Ctrl-shift-U does not work work when editor is focused #9895 #9943

Closed
wants to merge 3 commits into from

Conversation

yzykov
Copy link

@yzykov yzykov commented Mar 27, 2020

GSOC2020: Ctrl-shift-U does not work work when editor is focused #9895

  1. I have tested the changes on Windows, Linux & Mac
  2. I was following the existing style of the code. I noticed that SHORTCUT_SHIFT_KEY_MASK was missing and replaced with identical logic on line 1353. Therefore, I decided to create the variable.
  3. According to [1] iBus is not supporting CTRL+SHIFT+U. Modified to use CTRL+ALT+U for Linux.
    a) No users were affected on Windows and Mac OS, because preexisting behaviour is the same for Windows and Mac OS.
    b) Users with Linux XIM/None settings are affected, because the hotkeys were changed.
  4. Tested with XIM/None CTRL+SHIFT+U was working fine.
  5. Tested with iBus/XIM/None CTRL+ALT+U is working on Linux.

[1] https://superuser.com/questions/358749/how-to-disable-ctrlshiftu-in-ubuntu-linux

@yzykov yzykov closed this Mar 28, 2020
@yzykov yzykov deleted the new-branch branch March 28, 2020 04:04
@per1234 per1234 added Component: IDE The Arduino IDE Type: Bug labels Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants