-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP8266 ESP32 compatible #70
Open
mostafahk
wants to merge
10
commits into
arduino-libraries:master
Choose a base branch
from
mostafahk:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,809
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would works if my merge in ArduinoRS485 accepted. |
Memory usage change @ cd2120b
Click for full report table
Click for full report CSV
|
#include <HardwareSerial.h> needs to be included in ModbusRTUServer.cpp and ModbusRTUClient.cpp otherwise
|
Memory usage change @ a8e852e
Click for full report table
Click for full report CSV
|
Retry check to ignore AVR memory issue thanks to #106 to ease merge. |
1 similar comment
This comment was marked as duplicate.
This comment was marked as duplicate.
Don't work with esp8266 |
per1234
added
type: enhancement
Proposed improvement
topic: code
Related to content of the project itself
labels
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.