Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(arconnect): use signDataItem method, signature is deprecated PE-7455 #218

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

fedellen
Copy link
Collaborator

No description provided.

@fedellen fedellen self-assigned this Jan 17, 2025
@fedellen fedellen requested a review from a team as a code owner January 17, 2025 20:12
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 43.47826% with 13 lines in your changes missing coverage. Please review.

Project coverage is 93.40%. Comparing base (075fc15) to head (0cd3ca7).
Report is 12 commits behind head on alpha.

Files with missing lines Patch % Lines
src/web/signer.ts 43.47% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            alpha     #218      +/-   ##
==========================================
- Coverage   93.73%   93.40%   -0.33%     
==========================================
  Files          25       25              
  Lines        3541     3562      +21     
  Branches      160      161       +1     
==========================================
+ Hits         3319     3327       +8     
- Misses        222      235      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fedellen fedellen merged commit 2492624 into alpha Jan 17, 2025
8 of 9 checks passed
@fedellen fedellen deleted the PE-7455-arconnect-sign-data-item-api branch January 17, 2025 20:18
@dtfiedler
Copy link
Collaborator

🎉 This PR is included in version 1.21.1-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dtfiedler
Copy link
Collaborator

🎉 This PR is included in version 1.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants