Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PE-5029: adds a parameter to by pass the download verification #57

Conversation

thiagocarvalhodev
Copy link
Collaborator

  • adds a parameter verifyDownload to bypass the download verification
  • moves the graphql query to a utils file
  • minor refactors

- adds a parameter `verifyDownload` to bypass the download verification
- moves the graphql query to a utils file
- minor refactors
@thiagocarvalhodev thiagocarvalhodev self-assigned this Nov 16, 2023
remove try-catch block
refactors:
- now if we dont verify we won't create the split stream;
- minor refactors
- fix: was reading the wrong object json
- close stream when the download finishes
karlprieb
karlprieb previously approved these changes Nov 17, 2023
@thiagocarvalhodev thiagocarvalhodev merged commit 41d5906 into master Jan 4, 2024
3 checks passed
@thiagocarvalhodev thiagocarvalhodev deleted the PE-5029-suspend-data-item-validation-for-cli-uploads-during-download-to-investigate-root-cause branch January 4, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants