Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.4.4 #20

Conversation

thiagocarvalhodev
Copy link
Collaborator

@thiagocarvalhodev thiagocarvalhodev commented Nov 16, 2023

  • Adds the ardriveIODebugPrint method for logging
  • Close the finalize future when the upload is done

- complete future when the download is finished
- add debug logs
…-uploads-during-download-to-investigate-root-cause
@thiagocarvalhodev thiagocarvalhodev self-assigned this Nov 16, 2023
karlprieb
karlprieb previously approved these changes Nov 16, 2023
- rollback the changes on file saver. The issue on firefox still happening.
This reverts commit c22b22f.
karlprieb
karlprieb previously approved these changes Nov 17, 2023
@thiagocarvalhodev thiagocarvalhodev changed the title PE-5029: add debug logs and close future when download is finished v1.4.4 Jan 4, 2024
Copy link
Contributor

@matibat matibat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


void ardriveIODebugPrint(String message) {
if (kDebugMode) {
print('[ardrive_io] $message');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised that the linter doesn't complain about this print statement.

@thiagocarvalhodev thiagocarvalhodev merged commit 6ff48b9 into main Jan 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants