-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.4.4 #20
Merged
thiagocarvalhodev
merged 6 commits into
main
from
PE-5029-suspend-data-item-validation-for-cli-uploads-during-download-to-investigate-root-cause
Jan 4, 2024
Merged
v1.4.4 #20
thiagocarvalhodev
merged 6 commits into
main
from
PE-5029-suspend-data-item-validation-for-cli-uploads-during-download-to-investigate-root-cause
Jan 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- complete future when the download is finished - add debug logs
…-uploads-during-download-to-investigate-root-cause
karlprieb
previously approved these changes
Nov 16, 2023
- rollback the changes on file saver. The issue on firefox still happening.
This reverts commit c22b22f.
karlprieb
previously approved these changes
Nov 17, 2023
…-uploads-during-download-to-investigate-root-cause
thiagocarvalhodev
changed the title
PE-5029: add debug logs and close future when download is finished
v1.4.4
Jan 4, 2024
matibat
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
||
void ardriveIODebugPrint(String message) { | ||
if (kDebugMode) { | ||
print('[ardrive_io] $message'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised that the linter doesn't complain about this print statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ardriveIODebugPrint
method for logging