v1.4.0 #16
Closed
v1.4.0 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"This writable stream writer has been released and cannot be closed"
Used when FileSystemAPI is not available
MobileSelectableFolderFileSaver's FileSaver does not support streams
logic to prevent overwriting
reason: `extension` is dart reserved keyword (+ more explicit)
- add a method to save files on local app dir - ps: only mobile!
use static version
replace deprecated method
- Changes the implementation of the `listContent()` method to return the first level children of this folder. This behavior is already present on the `IOFolder` running on dart vm. - Implements a new interface `MutableIOFilePath` that allows the flexibility for change its own path. It is useful for generating the folder tree. `WebFile` now implements this interface. TODO: implement unit tests
renames mutable path variable
- implement recursive file tree generation for _WebFolder
Stream saving (+ misc fixes)
karlprieb
reviewed
Oct 6, 2023
| int progress = data[2]; | ||
|
|
||
| /// only track the progress of current task id | ||
| if (status == DownloadTaskStatus.enqueued) { | ||
| controller.sink.add(0); | ||
| } else if (status == DownloadTaskStatus.running) { | ||
| debugPrint('Download progress: ' + progress.toString()); | ||
| debugPrint('Download progress: $progress'); |
There was a problem hiding this comment.
can we get rid of this log?
fixes download on safari and firefox
thiagocarvalhodev
changed the title
matibat
previously approved these changes
Oct 26, 2023
| class SaveStatus { | ||
| final int bytesSaved; | ||
| final int totalBytes; | ||
| final bool? saveResult; |
There was a problem hiding this comment.
Does the null value have a specific meaning here? Is it different than defaulting to false?
Edit - Having it be null means the download hasn't yet finished.
There was a problem hiding this comment.
We can rename it to hasFinished or isResultSaved, or similar.
| try { | ||
| await _fileSaver.save(file); | ||
| await _fileSaver.save(file, saveOnAppDirectory: saveOnAppDirectory); |
There was a problem hiding this comment.
We can get rid of this try..catch because it's rethrowing and nothing else.
There was a problem hiding this comment.
Same comment for the method below.
|
|
||
| counter++; | ||
|
|
||
| // TODO: Throw an exception on arbitrarily large counter? |
| await writer.readyFuture; | ||
| debugPrint('writer ready'); | ||
|
|
||
| // FIXME: this never ends on Firefox/Safari. |
There was a problem hiding this comment.
Something to do here? - If not then let's remove the comment.
thiagocarvalhodev
dismissed
matibat’s stale review
The merge-base changed after approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
Now it's possible to save files as Stream on Android, iOS, and Web.
On the Web, it uses
FileSystemAccesswhen the browser supports it, otherwise, it will use theStreamSaver.Limitations