PE-7214: feat(primary name) #1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- load primary name
|
Visit the preview URL for this PR (updated for commit 05cd68d): https://ardrive-web--pr1927-pe-7214-show-ar-ns-p-6dio5wuy.web.app (expires Tue, 10 Dec 2024 19:34:26 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a224ebaee2f0939e7665e7630e7d3d6cd7d0f8b0 |
- refresh primary name when sync - add refresh name event on bloc - update ario sdk readme repo
- change cu URL - fix test
kunstmusik
reviewed
Dec 3, 2024
| return BlocBuilder<ProfileNameBloc, ProfileNameState>( | ||
| builder: (context, state) { | ||
| final primaryName = state is ProfileNameLoaded | ||
| ? state.primaryName |
There was a problem hiding this comment.
I think this won't truncate primary names to max 20 and add ... ? Or is it handled elsewhere?
kunstmusik
reviewed
Dec 3, 2024
kunstmusik
previously approved these changes
Dec 3, 2024
kunstmusik
approved these changes
Dec 3, 2024
thiagocarvalhodev
deleted the
PE-7214-show-ar-ns-primary-name-on-ar-drive
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--- Releases ---
Android release: https://appdistribution.firebase.google.com/testerapps/1:305132849030:android:6cf0cd5ec064fad3ffce07/releases/4c305ecg0kfig