Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(attach drives) #1917

Merged
merged 1 commit into from
Nov 18, 2024
Merged

fix(attach drives) #1917

merged 1 commit into from
Nov 18, 2024

Conversation

thiagocarvalhodev
Copy link
Collaborator

@thiagocarvalhodev thiagocarvalhodev commented Nov 18, 2024

@thiagocarvalhodev thiagocarvalhodev self-assigned this Nov 18, 2024
Copy link

⚠️ Your PR title does not match the required pattern. Please update the title in the format PE-{number}: {description}.

Comment on lines +135 to +136
if (state.userDrives.isNotEmpty ||
state.sharedDrives.isNotEmpty) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were showing the empty state when we only have shared drives

Copy link

Visit the preview URL for this PR (updated for commit 4681e2d):

https://ardrive-web--pr1917-fix-attach-drives-ys0iowq6.web.app

(expires Mon, 25 Nov 2024 12:40:39 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a224ebaee2f0939e7665e7630e7d3d6cd7d0f8b0

@thiagocarvalhodev thiagocarvalhodev changed the base branch from dev to master November 18, 2024 12:59
Copy link

⚠️ Your PR title does not match the required pattern. Please update the title in the format PE-{number}: {description}.

@atticusofsparta atticusofsparta self-requested a review November 18, 2024 13:35
@thiagocarvalhodev thiagocarvalhodev merged commit d2f596a into master Nov 18, 2024
6 of 7 checks passed
@thiagocarvalhodev thiagocarvalhodev deleted the fix-attach-drives branch November 18, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants