PE-7106: feat(custom manifest) #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- implement method to verify if the file is a custom manifest - add checkbox on upload form to user set the file as a manifest - upload file with the manifest content type
|
Visit the preview URL for this PR (updated for commit b489cfa): https://ardrive-web--pr1914-pe-7106-upload-custo-7tdqc5q0.web.app (expires Thu, 28 Nov 2024 11:33:27 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a224ebaee2f0939e7665e7630e7d3d6cd7d0f8b0 |
kunstmusik
reviewed
Nov 15, 2024
kunstmusik
reviewed
Nov 15, 2024
kunstmusik
reviewed
Nov 15, 2024
kunstmusik
reviewed
Nov 15, 2024
- rename variables - add validations on isCustomManifest method - update tests
fix lint
- remove NEQ operator and filter the licenses in the client
PE-7153: fix license sync
kunstmusik
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--- Releases ---
Android release: https://appdistribution.firebase.google.com/testerapps/1:305132849030:android:6cf0cd5ec064fad3ffce07/releases/02a5g9lrg67v8