Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PE-7037: missing hide show hidden items icon on android #1904

Conversation

thiagocarvalhodev
Copy link
Collaborator

@thiagocarvalhodev thiagocarvalhodev commented Oct 28, 2024

@thiagocarvalhodev thiagocarvalhodev self-assigned this Oct 28, 2024
@thiagocarvalhodev thiagocarvalhodev changed the base branch from dev to PE-6752-hide-drives October 28, 2024 12:47
Copy link

github-actions bot commented Oct 28, 2024

Visit the preview URL for this PR (updated for commit 8acbf55):

https://ardrive-web--pr1904-pe-7037-missing-hide-prmc4i5l.web.app

(expires Mon, 04 Nov 2024 14:48:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a224ebaee2f0939e7665e7630e7d3d6cd7d0f8b0

@@ -393,7 +393,8 @@ class HideBloc extends Bloc<HideEvent, HideState> {
performedAction:
settings.isHidden ? RevisionAction.hide : RevisionAction.unhide,
);
await _driveDao.updateDrive(driveCompanion.toEntryCompanion());

await _driveDao.insertDriveRevision(driveCompanion);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes another story bug where the revision was not displaying immediately on activity panel

}

await _userRepository.deleteUser();
await _databaseHelpers.deleteAllTables();
await (await _metadataCache).clear();
(await _metadataCache).clear();
_userStreamController.add(null);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@thiagocarvalhodev thiagocarvalhodev merged commit 9f47a53 into PE-6752-hide-drives Oct 28, 2024
6 checks passed
@thiagocarvalhodev thiagocarvalhodev deleted the PE-7037-missing-hide-show-hidden-items-icon-on-android branch October 28, 2024 17:43
@thiagocarvalhodev thiagocarvalhodev restored the PE-7037-missing-hide-show-hidden-items-icon-on-android branch October 28, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants