PE-6752: hide drives #1892
Merged
PE-6752: hide drives #1892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 9f47a53): https://ardrive-web--pr1892-pe-6752-hide-drives-16psnjy3.web.app (expires Mon, 04 Nov 2024 17:58:05 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a224ebaee2f0939e7665e7630e7d3d6cd7d0f8b0 |
- implement unit tests for the global_hide_bloc and user_prefs repository.
- fix infinite updates reacting to changes on user prefs repo
fix tests
lib/blocs/hide/hide_bloc.dart
Outdated
| } else if (entryIsFolder) { | ||
| newFolderEntry = currentEntry.copyWith( | ||
| isHidden: isHidden, | ||
| lastUpdated: DateTime.now(), |
There was a problem hiding this comment.
recommend declaring the timestamp as a const and then using it
lib/blocs/hide/hide_bloc.dart
Outdated
Comment on lines
281
to
285
| final hideAction = entryIsFile | ||
| ? (isHidden ? HideAction.hideFile : HideAction.unhideFile) | ||
| : (isHidden ? HideAction.hideFolder : HideAction.unhideFolder); | ||
| : entryIsDrive | ||
| ? (isHidden ? HideAction.hideDrive : HideAction.unhideDrive) | ||
| : (isHidden ? HideAction.hideFolder : HideAction.unhideFolder); |
There was a problem hiding this comment.
recommend declaring hide action up top and leveraging the if-if-else case above to set it
lib/components/app_top_bar.dart
Outdated
Comment on lines
79
to
88
| tooltip: hideState is ShowingHiddenItems | ||
| ? 'Hide hidden items' | ||
| : 'Show hidden items', | ||
| icon: hideState is ShowingHiddenItems | ||
| ? ArDriveIcons.eyeOpen( | ||
| color: colorTokens.textMid, | ||
| ) | ||
| : ArDriveIcons.eyeClosed( | ||
| color: colorTokens.textMid, | ||
| ), |
There was a problem hiding this comment.
seems like you could combine these ternaries
Comment on lines
+766
to
+774
| content: ArDriveDropdownItemTile( | ||
| name: item.isHidden | ||
| ? appLocalizationsOf(context).unhide | ||
| : appLocalizationsOf(context).hide, | ||
| icon: item.isHidden | ||
| ? ArDriveIcons.eyeOpen(size: defaultIconSize) | ||
| : ArDriveIcons.eyeClosed(size: defaultIconSize), | ||
| ), | ||
| ), |
There was a problem hiding this comment.
seems possible to combine ternaries here
There was a problem hiding this comment.
I meant more like:
content: ArDriveDropdownItemTile(
item.isHidden ? {
name: appLocalizationsOf(context).unhide,
icon: ArDriveIcons.eyeOpen(size: defaultIconSize)
} : {
name: appLocalizationsOf(context).hide,
icon: ArDriveIcons.eyeClose(size: defaultIconSize)
}
)
atticusofsparta
previously approved these changes
Oct 22, 2024
- refactor timestamp and action variables - remove the option to toggle hide state on the drive explorer (we don't use it anymore) - refactor where uses the drive detail state to know if we're showing hidden images
- refactor setHideStatus method
atticusofsparta
previously approved these changes
Oct 22, 2024
atticusofsparta
previously approved these changes
Oct 22, 2024
karlprieb
previously approved these changes
Oct 24, 2024
…dden-items-icon-on-android PE-7037: missing hide show hidden items icon on android
thiagocarvalhodev
dismissed stale reviews from karlprieb and atticusofsparta
via
9f47a53
karlprieb
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--- Releases ---
Android release: https://appdistribution.firebase.google.com/testerapps/1:305132849030:android:6cf0cd5ec064fad3ffce07/releases/4jrrs20qbdlv8