PE-6751: fixes autoupdate manifest payment selector #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- automatically start the upload if all manifest are free to upload
|
Visit the preview URL for this PR (updated for commit 0e62c9d): https://ardrive-web--pr1890-pe-6751-fixes-autoup-sphth8df.web.app (expires Tue, 22 Oct 2024 19:19:12 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a224ebaee2f0939e7665e7630e7d3d6cd7d0f8b0 |
lib/blocs/upload/upload_cubit.dart
Outdated
Comment on lines
721
to
723
| if (!isTest) { | ||
| await Future.delayed(const Duration(milliseconds: 100)); | ||
| } |
There was a problem hiding this comment.
whats up with this?
lib/blocs/upload/upload_cubit.dart
Outdated
Comment on lines
822
to
823
| await Future.delayed(const Duration(milliseconds: 100)); | ||
|
|
There was a problem hiding this comment.
a pattern i see, hmmmmm
| } | ||
| if (tasks.first is FileUploadTask) { | ||
| await _postUploadFile( | ||
| task: tasks.first as FileUploadTask, |
There was a problem hiding this comment.
Casting doesnt seem necessary here
There was a problem hiding this comment.
It is.
Dart’s type promotion has limitations:
- Local Variables Only: Type promotion works only with local variables, not with properties, getters, or index accesses. Since tasks.first is a property access (even if tasks is a local variable), type promotion doesn’t apply.
- Immutable Variables: The variable must not be mutated within the scope where the promotion is expected.
There was a problem hiding this comment.
Fair enough - maybe could create a local variable with a typeguard - consider having a util for this that returns "FileUploadTask". But not a blocker.
atticusofsparta
approved these changes
Oct 15, 2024
thiagocarvalhodev
deleted the
PE-6751-fixes-autoupdate-manifest-payment-selector
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--- Releases ---
Android release: https://appdistribution.firebase.google.com/testerapps/1:305132849030:android:6cf0cd5ec064fad3ffce07/releases/090vj6gqd4gi0