Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PE-6786: change payment method selector #1873

Conversation

thiagocarvalhodev
Copy link
Collaborator

@thiagocarvalhodev thiagocarvalhodev commented Sep 26, 2024

  • use new icons on checkbox
  • use new icons on license and change its style, also adds a question icon with a tooltip instead of a text link
  • changes the upload payment method selector (only applies to the upload flow)
  • FIXES:
    • the modal actions now have the correct title when checking the arns checkbox
    • arns checkbox now maintain its state
    • PE-6619

--- Releases ---
Android release: https://appdistribution.firebase.google.com/testerapps/1:305132849030:android:6cf0cd5ec064fad3ffce07/releases/2p1nltg456teg

- use new icons on checkbox
- use new icons on license and change its style, also adds a question icon with a tooltip instead of a text link
- changes the upload payment method selector (only applies to the upload flow)
- FIXES:
  - the modal actions now have the correct title when checking the arns checkbox
  - arns checkbox now maintain its state
@thiagocarvalhodev thiagocarvalhodev self-assigned this Sep 26, 2024
Copy link

github-actions bot commented Sep 27, 2024

Visit the preview URL for this PR (updated for commit 95ee158):

https://ardrive-web--pr1873-pe-6786-change-payme-uq7aw3zp.web.app

(expires Wed, 09 Oct 2024 14:01:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a224ebaee2f0939e7665e7630e7d3d6cd7d0f8b0

LICENSE Outdated Show resolved Hide resolved
@@ -1,4 +1,4 @@
/// Flutter icons ArDriveIcons
/// Flutter icons ArDriveIconsf
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ArDriveIconsf?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! 95ee158

@thiagocarvalhodev thiagocarvalhodev merged commit 2cb3ece into PE-6783-upload-modal-enhancements-dev Oct 2, 2024
2 checks passed
@thiagocarvalhodev thiagocarvalhodev deleted the PE-6786-change-payment-method-selector branch October 2, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants