-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PE-6709: navigate to drive explorer before wallet balance and io tokens fetch completion #1824
Merged
thiagocarvalhodev
merged 7 commits into
dev
from
PE-6623-navigate-to-drive-explorer-before-wallet-balance-and-io-tokens-fetch-completion
Sep 11, 2024
Merged
PE-6709: navigate to drive explorer before wallet balance and io tokens fetch completion #1824
thiagocarvalhodev
merged 7 commits into
dev
from
PE-6623-navigate-to-drive-explorer-before-wallet-balance-and-io-tokens-fetch-completion
Sep 11, 2024
+473
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
- fetch the balance async unlocking drive explorer faster - update ardrive auth user api - implement/update unit tests
Visit the preview URL for this PR (updated for commit 629ca5b): https://ardrive-web--pr1824-pe-6623-navigate-to-8vhdg2tg.web.app (expires Tue, 17 Sep 2024 15:27:02 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a224ebaee2f0939e7665e7630e7d3d6cd7d0f8b0 |
Base automatically changed from
PE-6610-network-errors-when-selecting-inactive-gateways
to
PE-6472-implement-ario-sdk-integration-gar
September 6, 2024 20:11
Base automatically changed from
PE-6472-implement-ario-sdk-integration-gar
to
dev
September 6, 2024 21:33
karlprieb
reviewed
Sep 9, 2024
lib/components/profile_card.dart
Outdated
@@ -500,7 +500,7 @@ class _ProfileCardState extends State<ProfileCard> { | |||
), | |||
if (ioTokens == null) | |||
Text( | |||
'An error occurred while fetching IO tokens', | |||
'Loading...', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentional?
…let-balance-and-io-tokens-fetch-completion
…let-balance-and-io-tokens-fetch-completion
- load tokens async - show error state when the io tokens fails to fetch - add refresh button
thiagocarvalhodev
changed the title
PE-6623: navigate to drive explorer before wallet balance and io tokens fetch completion
PE-6709: navigate to drive explorer before wallet balance and io tokens fetch completion
Sep 10, 2024
karlprieb
approved these changes
Sep 10, 2024
thiagocarvalhodev
deleted the
PE-6623-navigate-to-drive-explorer-before-wallet-balance-and-io-tokens-fetch-completion
branch
September 11, 2024 14:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--- Releases ---
Android release: https://appdistribution.firebase.google.com/testerapps/1:305132849030:android:6cf0cd5ec064fad3ffce07/releases/00p5mbmg4sioo