PE-4994: Prompt Users to Create a Snapshot #1517

matibat · 2023-12-12T05:50:41Z

Changes

Adds a new modal prompting to make a snapshot.
Makes the modal be triggered after selecting a drive, with a debouncer of 20s.
Makes the GQL Drive History count for the transactions, per drive.
Introduces a class responsible for tracking the count of transactions synced through GQL. As a second responsibility, it determines whether or not it's a good time to make a snapshot for a certain drive.
- Maybe TODO: Implement cache of TXs count.
After snapshot time, the TXs count gets reset.
- TODO: it should be aware of the non-snapshotted TXs after making one because of any recent uploads. That's a question: how many GQL-synced TXs didn't get snapshotted? This shouldn't conflict with the yet-not-synced ones.
- Maybe fix: get the last synced height and filter against the snapshot sync data.

Note - we're leaving those TODOs for a later improvement.

--- Releases ---
Android release: https://appdistribution.firebase.google.com/testerapps/1:305132849030:android:6cf0cd5ec064fad3ffce07/releases/1ijhutiqe6nno

github-actions · 2023-12-12T06:00:19Z

Visit the preview URL for this PR (updated for commit e643868):

https://ardrive-web--pr1517-pe-4994-1koigns7.web.app

_{(expires Tue, 30 Jan 2024 23:00:53 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: a224ebaee2f0939e7665e7630e7d3d6cd7d0f8b0}

matibat

Self-review checkpoint.

lib/blocs/prompt_to_snapshot/prompt_to_snapshot_bloc.dart

lib/pages/drive_detail/drive_detail_page.dart

lib/components/prompt_to_snapshot_dialog.dart

matibat · 2023-12-12T06:16:57Z

lib/components/create_snapshot_dialog.dart

For the reviewer - Renamed the ARB key for this because I created another with the same name.

matibat · 2023-12-12T06:18:55Z

lib/blocs/sync/utils/sync_drive.dart

  logger.d('Done fetching data - ${gqlDriveHistory.driveId}');

+  promptToSnapshotBloc.add(


For the reviewer - Here we pass the count to the cubit to let it consider whether to prompt to make a snapshot

… PE-4994

matibat · 2023-12-14T19:18:26Z

lib/app_shell.dart

+                      if (syncState is! SyncInProgress) {
+                        final promptToSnapshotBloc =
+                            context.read<PromptToSnapshotBloc>();
+                        promptToSnapshotBloc.add(SelectedDrive(


For the reviewer - we now add to the bloc the SelectDrive event after the sync has finished.

matibat · 2023-12-14T19:39:35Z

lib/blocs/prompt_to_snapshot/prompt_to_snapshot_bloc.dart

+    CountOfTxsSyncedWithGql.countForDrive(
+      event.driveId,
+      event.txsSyncedWithGqlCount,
+    );


For the reviewer - This is currently counting zero, but later on we're gonna track that number to be more precise.

matibat · 2023-12-14T19:42:41Z

lib/blocs/prompt_to_snapshot/prompt_to_snapshot_bloc.dart

+  }
+}
+
+abstract class CountOfTxsSyncedWithGql {


Hey, @thiagocarvalhodev, this is the class I mentioned earlier.

We can extend this class and/or compose it with other similar ones to track stats as you suggested.

And we can add the persistence here.

matibat

Self-review checkpoint.

lib/blocs/prompt_to_snapshot/prompt_to_snapshot_bloc.dart

…E-4994

lib/components/prompt_to_snapshot_dialog.dart

matibat

Self-review checkpoint.

lib/blocs/drives/drives_cubit.dart

…nstead of the caller PE-5254

matibat

Self-review checkpoint.

lib/blocs/drives/drives_cubit.dart

lib/blocs/prompt_to_snapshot/prompt_to_snapshot_bloc.dart

matibat · 2024-01-11T19:46:04Z

lib/blocs/prompt_to_snapshot/prompt_to_snapshot_state.dart

+  }
+}
+
+class PromptToSnapshotSnapshotting extends PromptToSnapshotState {


For the reviewer - Implemented a new state in order not to prompt while snapshotting.

matibat · 2024-01-11T19:46:34Z

lib/blocs/prompt_to_snapshot/prompt_to_snapshot_state.dart

+class PromptToSnapshotIdle extends PromptToSnapshotState {
+  const PromptToSnapshotIdle() : super(driveId: null);
+}


For the reviewer - Made the Idle state not to have a driveId.

matibat · 2024-01-11T19:47:13Z

lib/components/create_snapshot_dialog.dart

+              // TODO
+              /// txsSyncedWithGqlCount: state.notSnapshottedTxsCount,


For the reviewer - TODO for the next iteration

matibat · 2024-01-11T19:48:40Z

lib/components/create_snapshot_dialog.dart

For the reviewer -

Once the modal gets opened, it will tell the bloc we're snapshotting.

On success it will emit Snapshotted so the count gets reset.

Once it's closed, it will tell the bloc no drive is selected so it goes Idle.

- add event for when the modal is closed

…r-after-closing-with-x PE-5457: modal doesnt reappear after closing with x

matibat added 2 commits December 11, 2023 17:27

feat(prompt to snapshot): WIP PE-4994

72192f6

feat(prompt to snapshot): dialog PE-4994

def0599

feat(prompt to snapshot): removes hard-coded value PE-4994

68efc81

matibat commented Dec 12, 2023

View reviewed changes

matibat added 8 commits December 12, 2023 14:17

feat(prompt to snapshot): removes unnecessary logs PE-4994

53339b3

feat(prompt to snapshot): makes the bloc testable PE-4994

7a824ef

test(prompt to snapshot): unit tests for the bloc PE-4994

f1d8ce4

feat(prompt to snapshot): dont remind me again modal PE-4994

e13fcf8

test(prompt to snapshot): adds test case PE-4994

21b6980

feat(prompt to snapshot): wordings PE-4994

37a9646

feat(prompt to snapshot): cleans the dontremindmeagain flag on logout…

0cf2625

… PE-4994

chore(prompt to snapshot): removes unnecessary comment Pe4994

99c1c53

matibat marked this pull request as ready for review December 13, 2023 02:52

matibat added 2 commits December 14, 2023 16:05

feat(prompt to snapshot): do not prompt while sync is running PE-4994

bf3500f

chore(drive detail page): removes unnecessary comment PE-4994

9665ecf

matibat commented Dec 14, 2023

View reviewed changes

matibat added 3 commits December 14, 2023 16:36

feat(prompt to snapshot): logging PE-4994

23e2a71

Merge remote-tracking branch 'origin/dev' into PE-4994

e8735b7

Merge remote-tracking branch 'origin/PE-4994' into PE-4994

211622e

matibat commented Dec 14, 2023

View reviewed changes

atticusofsparta previously approved these changes Jan 3, 2024

View reviewed changes

thiagocarvalhodev self-assigned this Jan 5, 2024

thiagocarvalhodev previously approved these changes Jan 5, 2024

View reviewed changes

karlprieb reviewed Jan 8, 2024

View reviewed changes

lib/blocs/prompt_to_snapshot/prompt_to_snapshot_bloc.dart Outdated Show resolved Hide resolved

karlprieb reviewed Jan 8, 2024

View reviewed changes

lib/blocs/prompt_to_snapshot/prompt_to_snapshot_bloc.dart Outdated Show resolved Hide resolved

karlprieb reviewed Jan 8, 2024

View reviewed changes

lib/blocs/prompt_to_snapshot/prompt_to_snapshot_bloc.dart Outdated Show resolved Hide resolved

feat(prompt to snapshot bloc): uses a map for holding the TXs count P…

c17b849

…E-4994

matibat added 3 commits January 10, 2024 18:45

test(prompt to snapshot): updates unit tests PE-4994

17d651b

chore(drive detail page): removes uused variable PE-4994

41fb9ca

Merge remote-tracking branch 'origin/dev' into PE-4994

78164ba

matibat commented Jan 10, 2024

View reviewed changes

lib/components/prompt_to_snapshot_dialog.dart Outdated Show resolved Hide resolved

test(debouncer): implements unit tests PE-4994

9708365

matibat commented Jan 10, 2024

View reviewed changes

chore(prompt to snapshot dialog): reverts unnecessary change PE-4994

8569554

karlprieb reviewed Jan 11, 2024

View reviewed changes

lib/blocs/drives/drives_cubit.dart Outdated Show resolved Hide resolved

matibat added 4 commits January 11, 2024 15:20

feat(prompt to snapshot bloc): makes it check permissions by itself i…

cf3fd77

…nstead of the caller PE-5254

test(prompt to snapshot): updates unit test PE-5254

497bc0f

feat(prompt to snapshot): don-t prompt while snapshotting PE-4994

06e68c1

test(prompt to snapshot): unit tests snapshotting state PE-4994

f49bd81

matibat commented Jan 11, 2024

View reviewed changes

chore(cleanup): nit PE-4994

ccbef66

matibat requested a review from karlprieb January 11, 2024 19:51

karlprieb previously approved these changes Jan 12, 2024

View reviewed changes

thiagocarvalhodev and others added 2 commits January 19, 2024 09:12

fix(prompt snapshot)

bb67b10

- add event for when the modal is closed

Merge pull request #1565 from ardriveapp/PE-5457-modal-doesnt-reappea…

be4d8e8

…r-after-closing-with-x PE-5457: modal doesnt reappear after closing with x

thiagocarvalhodev dismissed karlprieb’s stale review via be4d8e8 January 19, 2024 19:19

Merge branch 'dev' into PE-4994

a55382e

thiagocarvalhodev previously approved these changes Jan 23, 2024

View reviewed changes

Merge branch 'dev' into PE-4994

290e008

thiagocarvalhodev dismissed their stale review via 290e008 January 23, 2024 15:36

thiagocarvalhodev previously approved these changes Jan 23, 2024

View reviewed changes

matibat removed their assignment Jan 23, 2024

Update main.dart

e643868

thiagocarvalhodev dismissed their stale review via e643868 January 23, 2024 22:49

thiagocarvalhodev approved these changes Jan 24, 2024

View reviewed changes

thiagocarvalhodev merged commit 8d4cdef into dev Jan 24, 2024
6 checks passed

thiagocarvalhodev deleted the PE-4994 branch January 24, 2024 13:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PE-4994: Prompt Users to Create a Snapshot #1517

PE-4994: Prompt Users to Create a Snapshot #1517

matibat commented Dec 12, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Dec 12, 2023 •

edited

Loading

matibat left a comment

matibat Dec 12, 2023

matibat Dec 12, 2023

matibat Dec 14, 2023

matibat Dec 14, 2023 •

edited

Loading

matibat Dec 14, 2023

matibat left a comment

matibat left a comment

matibat left a comment

matibat Jan 11, 2024

matibat Jan 11, 2024

matibat Jan 11, 2024

matibat Jan 11, 2024

		logger.d('Done fetching data - ${gqlDriveHistory.driveId}');

		promptToSnapshotBloc.add(

		// TODO
		/// txsSyncedWithGqlCount: state.notSnapshottedTxsCount,

PE-4994: Prompt Users to Create a Snapshot #1517

PE-4994: Prompt Users to Create a Snapshot #1517

Conversation

matibat commented Dec 12, 2023 • edited by github-actions bot Loading

Changes

github-actions bot commented Dec 12, 2023 • edited Loading

matibat left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

matibat Dec 14, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

matibat left a comment

Choose a reason for hiding this comment

matibat left a comment

Choose a reason for hiding this comment

matibat left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

matibat commented Dec 12, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Dec 12, 2023 •

edited

Loading

matibat Dec 14, 2023 •

edited

Loading