PE-4949: feat(bdi strategy upload) #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- implements the `UploadFileStrategy` to abstract the logic for how we upload the file using a bundle or data items - implemented factories and their tests - FIX ME: I noticed a problem on updating the status of the upload
|
Visit the preview URL for this PR (updated for commit 99cd461): https://ardrive-web--pr1490-pe-4949-change-bdi-s-bgtf0kp4.web.app (expires Mon, 15 Jan 2024 19:26:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a224ebaee2f0939e7665e7630e7d3d6cd7d0f8b0 |
remove prints
- decouples the controller from low-level classes like the streamed upload - refactors on the UploadTask APIs and on the UploadController FIX ME: there's a problem with the worker pool. Only from the second onwards are uploading. The first worker never uploads.
- fixes the worker pool not uploading the first task of each worker
remove unused elements
- implement a class to upload the folder structure as bundle
- add error handling UI
- introduces new classes for the exceptions on the uploader - improves the error handling on the TurboUploadService, UploadStrategy, StreamedUpload, and UploadDispatcher classes
- reset progress
…for-turbo-uploads-with-refactors PE-4949: (WIP): refactors and unit tests
…-ar-drive-app-v-2-27-0
karlprieb
previously approved these changes
Dec 12, 2023
- resets the total size when retrying the uploads
matibat
approved these changes
Jan 9, 2024
| @@ -746,14 +747,26 @@ class _UploadFormState extends State<UploadForm> { | |||
| } | |||
|
|
|||
| return ArDriveStandardModal( | |||
| title: appLocalizationsOf(context).uploadFailed, | |||
| width: kLargeDialogWidth, | |||
| title: 'Problem with Upload', | |||
| : [ | ||
| ModalAction( | ||
| action: () => Navigator.of(context).pop(false), | ||
| title: 'Do Not Fix', |
| action: () { | ||
| context.read<UploadCubit>().retryUploads(); | ||
| }, | ||
| title: 'Re-Upload', |
| '${filesize(((task.uploadItem!.size) * task.progress).ceil())}/${filesize(task.uploadItem!.size)}'; | ||
| if (task.uploadItem != null) { | ||
| progressText = | ||
| '${filesize(((task.uploadItem!.size) * task.progress).ceil())}/${filesize(task.uploadItem!.size)}'; |
There was a problem hiding this comment.
We could factor this out into its own testable and atomic function.
Comment on lines
+1177
to
+1178
| Text( | ||
| 'It seems there was a partial failure uploading the following file(s). The file(s) will show as failed in your drive. Please re-upload to fix.', |
| @@ -0,0 +1,103 @@ | |||
| abstract class ArDriveUploaderExceptions { | |||
There was a problem hiding this comment.
Nit
Suggested change
| abstract class ArDriveUploaderExceptions { | |
| abstract class ArDriveUploaderException { |
There was a problem hiding this comment.
Also, I'd say it should extend Exception.
Comment on lines
+37
to
+38
| default: | ||
| throw Exception('Invalid upload type'); |
There was a problem hiding this comment.
If UploadType is an enum with those two values then there's no default, so we shouldn't throw.
Comment on lines
+91
to
+92
| default: | ||
| throw Exception('Invalid upload type'); |
Comment on lines
+107
to
+117
| if (type == UploadType.d2n) { | ||
| return D2NStreamedUpload(); | ||
| } else if (type == UploadType.turbo) { | ||
| return TurboStreamedUpload( | ||
| TurboUploadServiceImpl( | ||
| turboUploadUri: turboUploadUri, | ||
| ), | ||
| ); | ||
| } else { | ||
| throw Exception('Invalid upload type'); | ||
| } |
There was a problem hiding this comment.
Consider using a switch-case with no default instead.
| Future<R> send( | ||
| class StreamedUploadResult { | ||
| final bool success; | ||
| final Object? error; |
There was a problem hiding this comment.
Should it be something like...
final Exception? exception;
|
@matibat's comments will be addressed on a new task. |
thiagocarvalhodev
deleted the
PE-4949-change-bdi-strategy-for-turbo-uploads
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UploadFileStrategyto abstract the logic for how we upload the file using a bundle or data items--- Releases ---
Android release: https://appdistribution.firebase.google.com/testerapps/1:305132849030:android:6cf0cd5ec064fad3ffce07/releases/6ra020rgoe8ro