Performance improvements on updating upload progress #1445
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Visit the preview URL for this PR (updated for commit 2b860fd): https://ardrive-web--pr1445-performance-improvem-1q62auut.web.app (expires Thu, 09 Nov 2023 12:29:57 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a224ebaee2f0939e7665e7630e7d3d6cd7d0f8b0 |
Base automatically changed from
PE-4754-address-code-review-comments-on-uploader-downloader-implementations
to
dev
October 26, 2023 19:03
- refactors the class moving the most important class at the top of the file - refactors the method to update the upload progress - removes a unused class
- Save the file on database when its upload finishes. - Introduces the `onCompleteTask` API on `UploadController`
|
|
remove noisy prints
|
|
|
Addressing this PR here: #1460 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--- Releases ---
Android release: https://appdistribution.firebase.google.com/testerapps/1:305132849030:android:6cf0cd5ec064fad3ffce07/releases/6up4hphejbf8g