PE-4808: makes turbo uploads be marked as not possible when size is below the limit #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ze is below the limit PE-4754
|
Visit the preview URL for this PR (updated for commit a79f08d): https://ardrive-web--pr1422-pe-4754-turbo-upload-kl3jox88.web.app (expires Wed, 01 Nov 2023 15:16:59 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a224ebaee2f0939e7665e7630e7d3d6cd7d0f8b0 |
matibat
changed the title
matibat
commented
Oct 17, 2023
| uploadPlanForAR.fileV2UploadHandles.isEmpty && | ||
| uploadPlanForTurbo.fileV2UploadHandles.isEmpty && |
There was a problem hiding this comment.
For the reviewer - This is the relevant change.
thiagocarvalhodev
approved these changes
Oct 25, 2023
thiagocarvalhodev
merged commit 49d7028
into
PE-4754-address-code-review-comments-on-uploader-downloader-implementations
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--- Releases ---
Android release: https://appdistribution.firebase.google.com/testerapps/1:305132849030:android:6cf0cd5ec064fad3ffce07/releases/41hn6ks5ic188