Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PE-4711: Audio Preview on Shared File Page #1399

Merged
merged 20 commits into from
Oct 31, 2023
Merged

PE-4711: Audio Preview on Shared File Page #1399

merged 20 commits into from
Oct 31, 2023

Conversation

matibat
Copy link
Contributor

@matibat matibat commented Oct 3, 2023

@matibat matibat self-assigned this Oct 3, 2023
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Visit the preview URL for this PR (updated for commit 82be171):

https://ardrive-web--pr1399-pe-4711-9k3x7nxa.web.app

(expires Tue, 07 Nov 2023 16:20:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a224ebaee2f0939e7665e7630e7d3d6cd7d0f8b0

Copy link
Collaborator

@thiagocarvalhodev thiagocarvalhodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. After removing the commented code I'll approve

flex: 2,
child: shareCard(),
),
// Flexible(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this change disappeared after integrating dev last week.

@matibat matibat changed the title PE-4711: Moves the details section of the Share Page to the right PE-4711: Audio Preview on Shared File Page Oct 6, 2023
@thiagocarvalhodev thiagocarvalhodev merged commit f947eef into dev Oct 31, 2023
6 checks passed
@thiagocarvalhodev thiagocarvalhodev deleted the PE-4711 branch October 31, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants