-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PE-4727: meta mask login #1398
PE-4727: meta mask login #1398
Conversation
Visit the preview URL for this PR (updated for commit 6f1f3ac): https://ardrive-web--pr1398-pe-4727-meta-mask-lo-g6k4f9xl.web.app (expires Tue, 24 Oct 2023 14:49:22 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a224ebaee2f0939e7665e7630e7d3d6cd7d0f8b0 |
This improves compatibility with some other wallets (e.g. Phantom)
Small tweak to support some other MetaMask-compatible wallets (e.g. Phantom) |
Request credentials before switching chain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Left some comments.
profileType INTEGER NOT NULL | ||
profileType INTEGER NOT NULL, | ||
|
||
-- Added in schema v18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I loved this comment. We shall start doing this for future changes. 🧠
|
Updates based on comments (WIP) #1421 |
lib/models/database/database.dart
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see... Some rubber-duck debugging here 🦆
- We don't have a migration strategy until the 17th one. So we do:
a.from >= 1 && from < 16
- When we're moving from migration v16 to v17, we do:
a.from < 17
- And when we're moving from the migration v17 to v18:
a.from < 18
- ✅ If we go from v1 to v18, then we fall in the 1st case.
- ❌ If we go from v16 to v18, then we fall in the 2nd case. - Here we'd be migrating to v17, and after the migration is done we'd still have an old migration.
- ✅ If we go from v17 to v18, then we fall in the 3rd case.
Please take a look to my thinking process, perhaps I got it wrong. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pe 4727 meta mask login migration
[WIP] Fixes for PE-4727 meta mask login
Closing this as the ETH login will be addressed in this PR: #1614 |
--- Releases ---
Android release: https://appdistribution.firebase.google.com/testerapps/1:305132849030:android:6cf0cd5ec064fad3ffce07/releases/4tbo3mdn0hh9o