PE-4694: Credit update issue during snapshot creation purchase #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matibat
commented
Sep 28, 2023
|
Visit the preview URL for this PR (updated for commit dfb546d): https://ardrive-web--pr1394-pe-4694-cqtdrw9m.web.app (expires Tue, 10 Oct 2023 17:14:04 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a224ebaee2f0939e7665e7630e7d3d6cd7d0f8b0 |
…rect turbo balance PE-4694
…ake amount of turbo balance, and dry run for the topup PE-4694
…up success PE-4694
| _configFetcher.saveConfigOnDevToolsPrefs(config); | ||
| _config = config; | ||
| void updateAppConfig(AppConfig newConfig) { | ||
| // logger.d('App config updated: ${config.diff(newConfig)}'); |
There was a problem hiding this comment.
This line of code breaks a unit test, but it's also useful for when adding new options. Should I simply remove it?
thiagocarvalhodev
approved these changes
Oct 3, 2023
| if (turbo.paymentStatus == PaymentStatus.success) { | ||
| logger.d('Turbo payment success'); | ||
|
|
||
| onSuccess?.call(); | ||
| } | ||
|
|
||
| turbo.dispose(); | ||
| }).whenComplete(() { |
Co-authored-by: Thiago Carvalho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--- Releases ---
Android release: https://appdistribution.firebase.google.com/testerapps/1:305132849030:android:6cf0cd5ec064fad3ffce07/releases/0bgop1j6s3fq8