-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PE-4533: Add Version Number to Login Screen #1391
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
632deb1
feat(app version widget): factors it out into its own source file PE-…
matibat 3070914
feat(login page): adds the version on the bottom of the login page fo…
matibat 791a442
feat(app version widget): makes the version component have the color …
matibat d2f279c
chore(app version widget): removes unnecessary log statements PE-4533
matibat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
import 'package:ardrive/utils/app_localizations_wrapper.dart'; | ||
import 'package:ardrive/utils/logger/logger.dart'; | ||
import 'package:ardrive_ui/ardrive_ui.dart'; | ||
import 'package:flutter/foundation.dart'; | ||
import 'package:flutter/material.dart'; | ||
import 'package:package_info_plus/package_info_plus.dart'; | ||
|
||
class AppVersionWidget extends StatelessWidget { | ||
final Color color; | ||
|
||
const AppVersionWidget({ | ||
Key? key, | ||
this.color = Colors.grey, | ||
}) : super(key: key); | ||
|
||
@override | ||
Widget build(BuildContext context) { | ||
return FutureBuilder( | ||
future: PackageInfo.fromPlatform(), | ||
builder: (BuildContext context, AsyncSnapshot<PackageInfo> snapshot) { | ||
final info = snapshot.data; | ||
if (info == null) { | ||
logger.d('PackageInfo is null'); | ||
return const SizedBox( | ||
height: 32, | ||
width: 32, | ||
); | ||
} | ||
final literalVersion = | ||
kIsWeb ? info.version : '${info.version}+${info.buildNumber}'; | ||
logger.d('Version: $literalVersion'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we remove this log? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed - d2f279c |
||
return Text( | ||
appLocalizationsOf(context).appVersion(literalVersion), | ||
style: ArDriveTypography.body.buttonNormalRegular( | ||
color: color, | ||
), | ||
textAlign: TextAlign.center, | ||
); | ||
}, | ||
); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed - d2f279c