Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PE-4397: Country Dropdown - Fixes #1388

Merged
merged 5 commits into from
Sep 28, 2023
Merged

PE-4397: Country Dropdown - Fixes #1388

merged 5 commits into from
Sep 28, 2023

Conversation

matibat
Copy link
Contributor

@matibat matibat commented Sep 27, 2023

Changes

  • Makes the dropdown overlay match the with of the field.
  • Moves the field just below the Credit Card one.

--- Releases ---
Android release: https://appdistribution.firebase.google.com/testerapps/1:305132849030:android:6cf0cd5ec064fad3ffce07/releases/066be3pi7skto

@matibat matibat self-assigned this Sep 27, 2023
@github-actions
Copy link

github-actions bot commented Sep 27, 2023

Visit the preview URL for this PR (updated for commit 8034723):

https://ardrive-web--pr1388-pe-4397-u9hw2rbh.web.app

(expires Thu, 05 Oct 2023 20:28:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a224ebaee2f0939e7665e7630e7d3d6cd7d0f8b0

Copy link
Collaborator

@thiagocarvalhodev thiagocarvalhodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +1024 to +1036
void _refreshChildWidth() {
final currentContext = _childKey.currentContext;
if (currentContext == null) {
return;
}

final RenderBox renderBox =
_childKey.currentContext!.findRenderObject() as RenderBox;

setState(() {
_childWidth = renderBox.size.width;
});
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked it

Copy link
Collaborator

@thiagocarvalhodev thiagocarvalhodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matibat matibat merged commit cd2424c into dev Sep 28, 2023
2 checks passed
@matibat matibat deleted the PE-4397 branch September 28, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants