Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PE-3953: sync-can-happen-in-background-when-creating-a-snapshot #1386

Merged

Conversation

kunstmusik
Copy link
Contributor

@kunstmusik kunstmusik commented Sep 26, 2023

Uses showModalDialog to mark add snapshot dialog as uninterruptible.

--- Releases ---
Android release: https://appdistribution.firebase.google.com/testerapps/1:305132849030:android:6cf0cd5ec064fad3ffce07/releases/7rhvrgren52qg

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit d94ce5b):

https://ardrive-web--pr1386-pe-3953-sync-can-hap-n6z20j8m.web.app

(expires Tue, 03 Oct 2023 21:10:31 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a224ebaee2f0939e7665e7630e7d3d6cd7d0f8b0

Copy link
Collaborator

@thiagocarvalhodev thiagocarvalhodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kunstmusik kunstmusik merged commit 5f41cea into dev Sep 27, 2023
6 checks passed
@kunstmusik kunstmusik deleted the PE-3953-sync-can-happen-in-background-when-creating-a-snapshot branch September 27, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants