PE-4676: Issues around the balance for snapshot creation #1385
Conversation
…method selector and not to be shown when turbo free uploads; makes the button be disabled when no balance PE-4676
…enough balance message PE-4676
|
Visit the preview URL for this PR (updated for commit 1a2e618): https://ardrive-web--pr1385-pe-4676-ehj8etbi.web.app (expires Tue, 03 Oct 2023 21:04:46 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a224ebaee2f0939e7665e7630e7d3d6cd7d0f8b0 |
There was a problem hiding this comment.
For the reviewer - This was making the button enabled state not to be updated.
There was a problem hiding this comment.
For the reviewer - This was causing the state for Upload File to not detect when the upload method changed so the "insufficient message" wasn't being updated.
There was a problem hiding this comment.
For the reviewer - Now this component is also having the "insufficient balance" message.
| @@ -136,7 +135,6 @@ class UploadForm extends StatefulWidget { | |||
|
|
|||
| class _UploadFormState extends State<UploadForm> { | |||
| final _scrollController = ScrollController(); | |||
| UploadMethod? _uploadMethod; | |||
There was a problem hiding this comment.
For the reviewer - Unused variable
| @@ -496,37 +492,32 @@ class _UploadFormState extends State<UploadForm> { | |||
| height: 8, | |||
| ), | |||
| }, | |||
| if (!state.isFreeThanksToTurbo) | |||
There was a problem hiding this comment.
For the reviewer - Now it's not necessary to run this check because the Widget does it under the hood.
| @@ -756,114 +747,4 @@ class _UploadFormState extends State<UploadForm> { | |||
| return const SizedBox(); | |||
| }, | |||
| ); | |||
|
|
|||
| Widget _getInsufficientBalanceMessage({ | |||
There was a problem hiding this comment.
For the reviewer - Now this piece is also part of the PaymentMethodSelector component.
Changes
--- Releases ---
Android release: https://appdistribution.firebase.google.com/testerapps/1:305132849030:android:6cf0cd5ec064fad3ffce07/releases/2hrepjq4mrcd0